From 24eadf0de85a010d4b5474206702805cec9f806a Mon Sep 17 00:00:00 2001
From: Meng Zhang <meng@tabbyml.com>
Date: Mon, 9 Oct 2023 11:34:56 -0700
Subject: [PATCH] refactor: make /v1/health accept GET requests (#527)

---
 crates/tabby/src/serve/health.rs | 2 +-
 crates/tabby/src/serve/mod.rs    | 8 +++++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/crates/tabby/src/serve/health.rs b/crates/tabby/src/serve/health.rs
index 9da45b8..0a5e0bf 100644
--- a/crates/tabby/src/serve/health.rs
+++ b/crates/tabby/src/serve/health.rs
@@ -92,7 +92,7 @@ impl Version {
 }
 
 #[utoipa::path(
-    post,
+    get,
     path = "/v1/health",
     tag = "v1",
     responses(
diff --git a/crates/tabby/src/serve/mod.rs b/crates/tabby/src/serve/mod.rs
index 5152c2e..ad595fe 100644
--- a/crates/tabby/src/serve/mod.rs
+++ b/crates/tabby/src/serve/mod.rs
@@ -201,11 +201,17 @@ fn api_router(args: &ServeArgs) -> Router {
         None
     };
 
+    let health_state = Arc::new(health::HealthState::new(args));
     let router = Router::new()
         .route("/v1/events", routing::post(events::log_event))
+        /* Remove POST /v1/health route in next major version release. */
         .route(
             "/v1/health",
-            routing::post(health::health).with_state(Arc::new(health::HealthState::new(args))),
+            routing::post(health::health).with_state(health_state.clone()),
+        )
+        .route(
+            "/v1/health",
+            routing::get(health::health).with_state(health_state),
         )
         .route(
             "/v1/completions",